Conversation
* dev: check templates are up to date * Touch template * Better feedback * Restore touched template
* dev: instructions for copilot reviews * Add info about testing
…2000) * Minimal spec for future property * Implementation & Test * Do not leak hidden property
…ject#2003) * attempt fixing workflow on aarch64 linux * dev: force macOS 14 macos-latest runner is now macOS 15 which breaks things, yet to diagnose... * fix: force macOS 14 in `ci-toolchain.yml` * dev: remove custom aarch case from `ci-release.yml` * Revert "dev: remove custom aarch case from `ci-release.yml`" This reverts commit 069997e. --------- Co-authored-by: Alejandro R Mosteo <amosteo@unizar.es>
…ject#2005) * Add test * Fix incidental output breaking structured output * Add note to `--format`'s description * Fix typo in test comment Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Absolutely no idea why this fails on gcc 10. I don't have it installed here as it's now masked and cannot be installed easily. This is the line: return (if Line (Line'First .. Line'First + Indicator'Length) = Indicator
then True else False);Would changing it to: return Line (Line'First .. Line'First + Indicator'Length) = Indicator;Instead work? |
|
Any ideas? |
|
I believe the issue is that Ada ranges are inclusive (not half-open intervals like many other languages), so you probably want something like return Line (Line'First .. Line'First + Indicator'Length - 1) = Indicator;I'm a little surprised that only GCC 10 catches this, though, so perhaps I'm missing something. I'm not familiar with the That said, it would likely be easier to just use the |
Check to make sure we have a line to check before checking the line.
* feat: minimal vetting of GH PATs * Old check when forcing
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Nothing I can do. |
You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-)) |
I've no idea what you're talking about here. I can't review it, it's not my project. |
| function Install (This : Deployer) return Outcome; | ||
|
|
||
| overriding | ||
| function Executable_Name (This : Deployer) return String is ("apt"); |
| Indicator : constant String := "[I]"; | ||
| Line : constant String := AAA.Strings.First_Element (Output); | ||
| begin | ||
| Trace.Info ("Already_Installed: " & This.Base.Package_Name); |
There was a problem hiding this comment.
Logging at info level in a deployer will be noisy/confusing, I suggest downgrading at least to detail.
| if Tmp (C) = L1.Low_Line then | ||
| Tmp (C) := L1.Hyphen; | ||
|
|
||
| Trace.Info ("To_Semantic_Version: " & Tmp); |
| end if; | ||
| end loop; | ||
|
|
||
| Trace.Info ("To_Semantic_Version: " & Tmp); |
I did the review, my fault, I had left in draft. |
|
No idea why this is failing. I don't know if it's me or not. |
As identified in this CI check, 60705e7 reverted the |
I think I merged an update rather than rebased. |
If this was addressed to me, I'm afraid I don't entirely understand what you mean. That 8dd254d was a merge commit was never in dispute. Apologies if my previous comment didn't make it clear, but the provenance of the change is not important. All I was really trying to say is that, as far as I can tell, the CI is failing because |
Ok, I've no clue about any of that. |
|
I'll fix that |
|
@Lucretia would you be willing to prepare a Docker file so we can test crates on gentoo? Akin to the ones we have in https://github.com/alire-project/dockerfiles |
|
I don't know anything about docker. You can run gentoo within a chroot if gh doesn't have a gentoo runner. |
|
@mosteo I can handle that. We welcome upstreams being keen to test on Gentoo. |
|
Thanks @Lucretia |
That's great, Sam. |
|
There is this: https://github.com/gentoo/gentoo-docker-images Oh that's Gentoo Sam, so he'll already know about that. |
7 participants
Adds in support for Gentoo's Portage.
PR creation checklist
doc/user-changes.mdhas been updated, if there are user-visible changes.doc/catalog-format-spec.mdhas been updated, if applicable.BREAKING.mdhas been updated for major changes inalr, minor/major in catalog format.